Skip to content

Border Controls: Add placeholders and base styles #34465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stacimc wants to merge 10 commits into from
Closed

Border Controls: Add placeholders and base styles #34465

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb55c52
Add: API to allow blocks to access global styles.
jorgefilipecosta Aug 19, 2021
42e28f2
Update packages/block-editor/src/utils/style-variable-resolution.js
jorgefilipecosta Aug 31, 2021
a3add41
Update packages/edit-site/src/components/editor/global-styles-provide…
jorgefilipecosta Aug 31, 2021
862c549
Feedback applied
jorgefilipecosta Aug 31, 2021
4be7074
Select border style when width or color change
stacimc Sep 1, 2021
a91a341
Add border color placeholder
stacimc Sep 1, 2021
9aeb01e
Pass color value rather than slug as prop, to fix preset color preview
stacimc Sep 1, 2021
a44b25f
Add placeholders for border radius
stacimc Sep 2, 2021
4eed22a
Use value (rather than value + unit) for width placeholder
stacimc Sep 2, 2021
28346ba
Remove style as a default control for Group
stacimc Sep 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update packages/block-editor/src/utils/style-variable-resolution.js 
Co-authored-by: André <[email protected]>
  • Loading branch information
@jorgefilipecosta @oandregal @stacimc
2 people authored and stacimc committed Sep 1, 2021
commit 42e28f203e9e805b88c2096a5b89cdd3d3b1dc13
2 changes: 1 addition & 1 deletion packages/block-editor/src/utils/style-variable-resolution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ export function getResolvedStyleVariable( features, context, variable ) {
.slice( CSS_REFERENCE_PREFIX.length, -CSS_REFERENCE_SUFFIX.length )
.split( '--' );
} else {
// Value is raw.
// We don't know how to parse the value: either is raw of uses complex CSS such as `calc(1px * var(--wp--variable) )`
return variable;
}

Expand Down