Skip to content

[RNMobile] Scroll header toolbar to end when RTL #34617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hypest merged 6 commits into from
Sep 10, 2021
Merged

[RNMobile] Scroll header toolbar to end when RTL #34617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc092fb
Scroll header toolbar to end when RTL
hypest Sep 7, 2021
6ad47e5
Update changelog
hypest Sep 7, 2021
7033b67
Only apply scrollToEnd on Android
hypest Sep 8, 2021
7703035
Merge branch 'trunk' into rnmobile/fix-rtl-header-toolbar-inserter
hypest Sep 9, 2021
a658c3a
Merge branch 'trunk' into rnmobile/fix-rtl-header-toolbar-inserter
hypest Sep 10, 2021
0a88109
Rephrase changelog to denote Android only issue
hypest Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/edit-post/src/components/header/header-toolbar/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import { ScrollView, View } from 'react-native';
import { Platform, ScrollView, View } from 'react-native';

/**
* WordPress dependencies
Expand Down Expand Up @@ -43,7 +43,13 @@ function HeaderToolbar( {
} ) {
const scrollViewRef = useRef( null );
const scrollToStart = () => {
scrollViewRef.current.scrollTo( { x: 0 } );
// scrollview doesn't seem to automatically adjust to RTL on Android so, scroll to end when Android
const isAndroid = Platform.OS === 'android';
if ( isAndroid && isRTL ) {
scrollViewRef.current.scrollToEnd();
} else {
scrollViewRef.current.scrollTo( { x: 0 } );
}
};
const renderHistoryButtons = () => {
const buttons = [
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-editor/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ For each user feature we should also add a importance categorization label to i
- [**] [Embed block] Implement WP embed preview component [#34004]
- [*] [Embed block] Fix content disappearing on Android when switching light/dark mode [#34207]
- [*] Embed block: Add device's locale to preview content [#33858]
- [**] Fix Android-only issue of main toolbar initial position being wrong when RTL [#34617]

## 1.61.0
- [**] Enable embed preview for a list of providers (for now only YouTube and Twitter) [#34446]
Expand Down