Widget Group: Make title directly editable #34799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
[Type] Enhancement
|
Size Change: +1.53 kB (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
Contributor
|
This works nicely and feels a lot smoother than the Legacy Widget-like approach. Thanks @noisysocks! |
Contributor
|
+1, this felt easier to work with. I wonder if the default placeholder text should be something like Widget group title instead of the name of the first block type that is added? But perhaps that should be in a separate issue? |
Contributor
I like this idea @carolinan. Maybe just Title is enough? Also I was wondering if we should try to make it similar to the way placeholder text works on a Heading block now that we've gone down the directly editable path. In that case it would have: • Gray placeholder text as the default But curious to hear what others think? |
Member
Author
|
Here's how that looks! Kapture.2021-09-17.at.14.22.16.mp4 |
Contributor
|
Nice! |
Contributor
|
I find it very clumsy that the Title placeholder just stays there giving the impression that it will also be displayed on the front end. You just want to remove it, because the block editor resembles what we display more or less. So this Title placeholder looks like an artifact that is somewhat broken. |
Contributor
@draganescu The same could be said about the Heading block, no? FWIW neither feel clumsy or broken to me 😅 IMO, this treatment of the placeholder text is an improvement because:
|
Contributor
|
I agree @critterverse pherhaps I am a bit stuck with the fact that is optional and I want to remove it :)) |
draganescu
approved these changes
Sep 21, 2021
Contributor
draganescu
left a comment
draganescu
left a comment
There was a problem hiding this comment.
I think this is an improvement over the previous interaction. I also like how we remove code to implement this. Win!
Contributor
@draganescu Opened a potential follow up issue that might help with this! #35017 |
noisysocks
deleted the
update/make-widget-group-title-directly-editable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the design feedback in #34484 (comment).
This changes the Widget Group block so that the title is directly editable using a
RichText. It's a little disingenuous to do this because the title isn't truly WYSIWYG, but it has the benefit of meaning that elements don't jump around the screen when you select the Widget Group.How has this been tested?
Screenshots
Kapture.2021-09-14.at.14.15.46.mp4
Checklist:
*.native.jsfiles for terms that need renaming or removal).