Skip to content

Image Block: Always use integer values for the image size #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
youknowriad merged 1 commit into from
Nov 15, 2017
Merged

Image Block: Always use integer values for the image size #3495

youknowriad merged 1 commit into from
Nov 15, 2017

Conversation

@youknowriad
Copy link
Contributor

@youknowriad youknowriad commented Nov 15, 2017

Width and Height should always be integers

Testing instructions

  • Create a post
  • Add an image block
  • Resize
  • Check the text mode
  • Widths and Heights should be integers

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label Nov 15, 2017
@youknowriad youknowriad self-assigned this Nov 15, 2017
jorgefilipecosta
jorgefilipecosta approved these changes Nov 15, 2017
View reviewed changes
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works great, no problem found.

@youknowriad youknowriad mentioned this pull request Nov 15, 2017
Closed
@youknowriad youknowriad merged commit 1243d46 into master Nov 15, 2017
@youknowriad youknowriad deleted the fix/integer-values-for-image-size branch November 15, 2017 13:32
@MaxMood96 MaxMood96 mentioned this pull request Dec 20, 2023
Open
@naiba4 naiba4 mentioned this pull request Dec 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduth aduth aduth approved these changes

@jorgefilipecosta jorgefilipecosta jorgefilipecosta approved these changes

Assignees

@youknowriad youknowriad

Labels

[Feature] Blocks Overall functionality of blocks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youknowriad @aduth @jorgefilipecosta