[RNMobile][Embed block] Disable inline preview for specific WP embed providers #34951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now Pinterest is the only WP embed provider not supported.
fluiddot
added
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
2 tasks
jd-alexander
approved these changes
Sep 20, 2021
Contributor
jd-alexander
left a comment
jd-alexander
left a comment
There was a problem hiding this comment.
Thanks for these changes @fluiddot I verified that on a previous gb-mobile version the Pinterest provider was rendered but when I fired up Metro Server for this PR and served the assets, the provider was no longer displaying an inline preview. LGTM 🚢
| Before | After |
|---|---|
 |
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3991Description
The inline preview for Pinterest URLs is not yet supported, however, it's currently being shown. This is caused because this provider is being rendered as a WordPress embed, in which inline previews are enabled independently to the provider. For this reason, we're adding a list of unsupported providers for the WordPress embeds that will disable it.
How has this been tested?
Screenshots
N/A
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).