Framework: Preserve settings when rebooting from crash

[aduth]

Related: #3208 (comment)

This pull request seeks to ensure that editor settings are respected when attempting to reboot from a crashed state. See #3208 (comment) for more context.

Testing instructions:

Ideally there is no way to create a crash in the application. You may introduce one though with the following diff:

diff --git a/components/dropdown/index.js b/components/dropdown/index.js
index 1989f101..1c79f148 100644
--- a/components/dropdown/index.js
+++ b/components/dropdown/index.js
@@ -61,6 +61,7 @@ class Dropdown extends Component {
 
        render() {
                const { isOpen } = this.state;
+               if ( isOpen ) throw new Error();
                const { renderContent, renderToggle, position = 'bottom', className, contentClassName } = this.props;
                const args = { isOpen, onToggle: this.toggle, onClose: this.close };
                return (

After applying these changes, add a breakpoint in the recreateEditorInstance function, incur the crash by opening a dropdown (e.g. inserter menu), then "Attempt Restore" and verify that recreateEditorInstance is called with the original settings of the editor.

[codecov]

Codecov Report

Merging #3500 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #3500   +/-   ##
=======================================
  Coverage   34.61%   34.61%           
=======================================
  Files         260      260           
  Lines        6757     6757           
  Branches     1226     1226           
=======================================
  Hits         2339     2339           
  Misses       3728     3728           
  Partials      690      690

Impacted Files	Coverage Δ
editor/index.js	0% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5255c93...46cd3bb. Read the comment docs.

[gziolo]

Setting needs to be passed here, too

[gziolo]

‘settings’ - I’m on mobile 😃

[aduth]

febf5d9

[gziolo]

Thanks for fixing this potential issue 👍