Skip to content

Refactor how the Global Styles access and sets data #35264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowriad merged 15 commits into from
Oct 7, 2021
Merged

Refactor how the Global Styles access and sets data #35264

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
08ecb51
Refactor how the Global Styles access and sets data
youknowriad Sep 30, 2021
5852786
Wire hooks to the variable engine
jorgefilipecosta Oct 3, 2021
c8296e3
Add missing return
youknowriad Oct 4, 2021
8858351
Make global styles updates independent of the component lifecycle
youknowriad Oct 4, 2021
4599b51
Simplify global styles renderer and remove useless code
youknowriad Oct 4, 2021
8e1bef0
Remove old useSetting
youknowriad Oct 4, 2021
0c6fbcf
Fix block global styles
youknowriad Oct 5, 2021
6e11eb5
Move all the global styles logic to the global styles folder
youknowriad Oct 5, 2021
65bd583
Add documentation
youknowriad Oct 5, 2021
0f3c757
Fix unit tests
youknowriad Oct 5, 2021
854e51c
Fix settings updates
youknowriad Oct 6, 2021
ead2bb3
Fix useSetting calls
youknowriad Oct 6, 2021
ebfa9ab
Fix elements outputs
youknowriad Oct 7, 2021
50bc2ad
Fix wrong useSetting usage
youknowriad Oct 7, 2021
0793abc
Fix unit tests
youknowriad Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix wrong useSetting usage
  • Loading branch information
@youknowriad
youknowriad committed Oct 7, 2021
commit 50bc2adfef2b4e608d8571129dfc9eba9601b437
14 changes: 11 additions & 3 deletions packages/edit-site/src/components/global-styles/color-palette-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,17 @@ const EMPTY_ARRAY = [];

export default function ColorPalettePanel( { name } ) {
const [ colors, setColors ] = useSetting( 'color.palette', name );
const userColors = useSetting( 'color.palette', name, 'user' );
const baseGlobalPalette = useSetting( 'color.palette', undefined, 'base' );
const baseContextualPalette = useSetting( 'color.palette', name, 'base' );
const [ userColors ] = useSetting( 'color.palette', name, 'user' );
const [ baseGlobalPalette ] = useSetting(
'color.palette',
undefined,
'base'
);
const [ baseContextualPalette ] = useSetting(
'color.palette',
name,
'base'
);
const immutableColorSlugs = useMemo( () => {
const basePalette = baseContextualPalette ?? baseGlobalPalette;
if ( ! basePalette ) {
Expand Down