Skip to content

Navigator: hide scrollbars while animating #35317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ciampo wants to merge 5 commits into from
Closed

Navigator: hide scrollbars while animating #35317

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2a7f474
`NavigatorContext`: refactor type, add `isAnimating`/`setAnimating`
ciampo Oct 4, 2021
479bb57
`NavigatorProvider`: apply `overflow: hidden` while screens are anima…
ciampo Oct 4, 2021
53e43fb
Added dialog to storybook
ciampo Oct 4, 2021
814b03d
Rename Navigator context properties
ciampo Oct 5, 2021
5a17e72
Set `isAnimating` only when `prefers-reduced-motion` is not enabled
ciampo Oct 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Set isAnimating only when prefers-reduced-motion is not enabled
  • Loading branch information
@ciampo
ciampo committed Oct 5, 2021
commit 5a17e725b1a22bd936d00724f9058432488304ba
6 changes: 5 additions & 1 deletion packages/components/src/navigator/use-navigator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
/**
* WordPress dependencies
*/
import { useReducedMotion } from '@wordpress/compose';
import { useContext } from '@wordpress/element';

/**
Expand All @@ -14,10 +15,13 @@ import type { Navigator } from './types';
*/
function useNavigator(): Navigator {
const { setLocation, setIsAnimating } = useContext( NavigatorContext );
const prefersReducedMotion = useReducedMotion();

return {
push( path, options ) {
setIsAnimating( true );
if ( ! prefersReducedMotion ) {
setIsAnimating( true );
}
setLocation( { path, ...options } );
},
};
Expand Down