Skip to content

Try: Site Logo placeholder tweaks #35397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasmussen merged 12 commits into from
Oct 8, 2021
Merged

Try: Site Logo placeholder tweaks #35397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
af55ccb
Initial work.
jasmussen Oct 6, 2021
daba47c
Add illustration.
jasmussen Oct 6, 2021
1fc4596
Add animation.
jasmussen Oct 6, 2021
197fa4f
Border radius.
jasmussen Oct 6, 2021
c252863
Site Logo: use custom media logo button
gwwar Oct 6, 2021
94594ac
Site Logo: pass through custom placeholder and remove z-index rules 🔪
gwwar Oct 6, 2021
3bdb879
Site Logo: add a tooltip on hover
gwwar Oct 6, 2021
eed6ec5
Site Logo: use snackbar for errors
gwwar Oct 6, 2021
8084312
Tweak the hover/select mechanism, polish.
jasmussen Oct 7, 2021
2142224
Provide size smarts, and fix a radius issue.
jasmussen Oct 7, 2021
ea0da01
Add comment to currentColor property.
jasmussen Oct 7, 2021
166a766
Add blinking fix.
jasmussen Oct 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Border radius.
  • Loading branch information
@jasmussen
jasmussen committed Oct 8, 2021
commit 197fa4f9fe0b0c77842ecfacf57ced9cef2af13e
8 changes: 6 additions & 2 deletions packages/block-library/src/site-logo/editor.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@
// and provides the on-hover upload button.
// That would also let it work with with less specificity.
.wp-block-site-logo.wp-block-site-logo {
// Inherit border radius from style variations.
.components-placeholder,
.components-resizable-box__container {
border-radius: inherit;
}

.components-placeholder {
justify-content: center;
align-items: center;
Expand All @@ -57,8 +63,6 @@
height: 120px;
padding: 0;

// Inherit border radius from style variations.
border-radius: inherit;

// Hide the upload button, as it's also available in the media library.
.components-form-file-upload {
Expand Down
5 changes: 4 additions & 1 deletion packages/block-library/src/site-logo/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,11 @@
&.is-default-size img {
width: 120px;
height: auto;
}

// Inherit border radius from style variations.
// Inherit border radius from style variations.
&.is-default-size a,
&.is-default-size img {
border-radius: inherit;
}

Expand Down