Find tests in nested directories #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
Framework
Potentially a bug with Webpack being unable to find keys to export from wildcard?
Avoid referring to registration as canonical "blocks"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request splits general test and export structuring refactoring from #335 and #348 . Previously parser tests weren't being run because they were defined in a nested directory. Upon including those tests, errors began to occur due to circular dependencies in Webpack (see webpack/webpack#1788). The changes here resolve this by moving the registration behaviors into its own file so the dependency between the parser and registration is more direct. In doing so, the
blocksfolder was flattened to bringparserto the top-level directory.