Skip to content

Update Navigator styling to facilitate sticky positioning #35518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stokesman merged 6 commits into from
Oct 12, 2021
Merged

Update Navigator styling to facilitate sticky positioning #35518

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1beee74
Add style to facilitate sticky positioning within `Navigator`
stokesman Oct 6, 2021
6fad862
Add screen with sticky position to Navigator story
stokesman Oct 10, 2021
283db02
Use classnames hook instead of inline styles
stokesman Oct 12, 2021
0db480d
Pare down filler text component
stokesman Oct 12, 2021
a29b9ce
Fix casing of style rules
stokesman Oct 12, 2021
d8b66a4
Differentiate buttons
stokesman Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Differentiate buttons 
Co-authored-by: Marco Ciampini <[email protected]>
  • Loading branch information
@stokesman @ciampo
stokesman and ciampo committed Oct 12, 2021
commit d8b66a4decf31c97e931f1bfb99ae23f2c26d4af
9 changes: 7 additions & 2 deletions packages/components/src/navigator/stories/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ function NavigatorButton( { path, isBack = false, ...props } ) {
const navigator = useNavigator();
return (
<Button
variant="secondary"
onClick={ () => navigator.push( path, { isBack } ) }
{ ...props }
/>
Expand All @@ -41,7 +42,7 @@ const MyNavigation = () => {
<p>This is the home screen.</p>

<HStack justify="flex-start" wrap>
<NavigatorButton variant="primary" path="/child">
<NavigatorButton path="/child">
Navigate to child screen.
</NavigatorButton>

Expand All @@ -54,7 +55,11 @@ const MyNavigation = () => {
</NavigatorButton>

<Flyout
trigger={ <Button>Open test dialog</Button> }
trigger={
<Button variant="primary">
Open test dialog
</Button>
}
placement="bottom-start"
>
<CardHeader>Go</CardHeader>
Expand Down