Fix invisible bottom sheet backdrop on Android #35557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Animating the opacity for the initial modal results in the backdrop provided by `react-native-modal` to never transition from transparent to partially opaque black. The core issue was not idenfited, but it may relate to the experimental state of LayoutAnimation for Android. https://reactnative.dev/docs/layoutanimation
dcalhoun
added
[Type] Bug
2 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
illusaen
approved these changes
Oct 12, 2021
Contributor
illusaen
left a comment
illusaen
left a comment
There was a problem hiding this comment.
The changes look good to me.
Contributor
|
Approved changes although you might want to look at that failing test... it doesn't look like an intermittent error. |
Contributor
|
@dcalhoun, I'm seeing this behavior with the demo app (notice that the right side fills in after a delay). Is this a concern, or reproducible on WPAndroid? landscape-opacity.mov |
Contributor
Member
Author
In the Demo app, I am able to reproduce the issue you mentioned on android-rotation-backdrop-delay.mp4Additionally, the WPAndroid app appears — for better or worse — to dismiss any editor modal whenever a rotation event occurs, so this particular issue does not occur. |
SiobhyB
approved these changes
Oct 12, 2021
Contributor
|
Thanks @SiobhyB! |
…id-bottom-sheet-overlay
Attempt to resolve flaky, failing e2e tests.
dcalhoun
added a commit
that referenced
this pull request
Oct 12, 2021
* Fix invisible bottom sheet backdrop on Android Animating the opacity for the initial modal results in the backdrop provided by `react-native-modal` to never transition from transparent to partially opaque black. The core issue was not idenfited, but it may relate to the experimental state of LayoutAnimation for Android. https://reactnative.dev/docs/layoutanimation * Update change log * Empty commit to trigger rebuilds Attempt to resolve flaky, failing e2e tests.
dcalhoun
added a commit
that referenced
this pull request
Oct 13, 2021
* Release script: Update react-native-editor version to 1.63.0 * Release script: Update with changes from 'npm run core preios' * Update react-native-editor changlog for 1.63.0 * [RNMobile] Remove unneeded memoization dependency from useBlockEditorSettings (#35289) * Release script: Update react-native-editor version to 1.63.1 * Release script: Update with changes from 'npm run core preios' * Fix overflowing content for native Help screen (#35552) * Fix overflowing content for Help screen When navigating to a Help section child screen, the parent screen would remain visible outside of the container. Hiding the overflow of the containing element fixes this. The reason this occurred for the first time now is likely because it is the first time we have utilized the default navigation transitions for the platforms, which is provided by React Navigation. This means the screen animates from right to left on iOS, rather than a cross-fade. * Update change log * Fix invisible bottom sheet backdrop on Android (#35557) * Fix invisible bottom sheet backdrop on Android Animating the opacity for the initial modal results in the backdrop provided by `react-native-modal` to never transition from transparent to partially opaque black. The core issue was not idenfited, but it may relate to the experimental state of LayoutAnimation for Android. https://reactnative.dev/docs/layoutanimation * Update change log * Empty commit to trigger rebuilds Attempt to resolve flaky, failing e2e tests. Co-authored-by: Paul Von Schrottky <[email protected]> Co-authored-by: Carlos Garcia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
Description
Relates to wordpress-mobile/gutenberg-mobile#4104. Animating the opacity for the initial modal results in the backdrop provided by
react-native-modalto never transition from transparent to partially opaque black. The core issue was not idenfited, but it may relate to the experimental state of LayoutAnimation for Android.How has this been tested?
Help modal
Full-screen Cover Block Edit Focal Point
Full-screen Link Picker
Screenshots
Types of changes
Bug fix
Checklist:
*.native.jsfiles for terms that need renaming or removal).