Skip to content

Navigation Block: Add missing menu item attributes to core/navigation #35634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 11 commits into from
Nov 2, 2021
Merged

Navigation Block: Add missing menu item attributes to core/navigation #35634

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
08a0601
Navigation Block: add target, rel & title attributes
mikachan Oct 14, 2021
dae69cf
Nav block: change title to attr_title
mikachan Oct 15, 2021
00ec38e
Nav block: add classes attribute
mikachan Oct 15, 2021
d006b41
Nav block: add menu item ID
mikachan Oct 20, 2021
ce01a7f
Merge branch 'trunk' into fix/navigation-menu-item-attrs
mikachan Oct 20, 2021
691c15a
Nav block: replace className with classes
mikachan Oct 20, 2021
e0d8ae5
Nav block: add description, kind & type attributes
mikachan Oct 20, 2021
10181ce
Nav block: improve id attribute
mikachan Oct 20, 2021
376f071
Nav block: remove array to string conversion from navigation-link
mikachan Oct 22, 2021
198297d
Nav block: change classes to className
mikachan Oct 22, 2021
095c880
Merge branch 'trunk' into fix/navigation-menu-item-attrs
mikachan Oct 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Nav block: change title to attr_title
  • Loading branch information
@mikachan
mikachan committed Oct 15, 2021
commit dae69cf939935caf712b6654de42a0d2b0e8b119
2 changes: 1 addition & 1 deletion packages/block-library/src/navigation/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ function gutenberg_parse_blocks_from_menu_items( $menu_items, $menu_items_by_par
'label' => $menu_item->title,
'opensInNewTab' => $opens_in_new_tab,
'rel' => $rel,
'title' => $menu_item->title,
'title' => $menu_item->attr_title,
'url' => $menu_item->url,
),
);
Expand Down