[Block Editor]: Fix displaying only the none alignment option
#35822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
requested review from
Mamaduka,
carolinan,
jameskoster,
jasmussen,
kjellr,
mcsf,
oandregal and
youknowriad
|
Size Change: +33 B (0%) Total Size: 1.07 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Oct 21, 2021
Contributor
|
Nice work. Before I see alignments with just "none": After this PR, they are gone:
Cool beans, this seems to just need a code review. On a separate note, and not something to fix here, I noticed text aligns have this "hint" coloration:
It shouldn't, that's toggle/inversion style is only for the inline formatting menu. For these alignments, the icon itself changes, which is sufficient. These alignments do it right:
Not the biggest issue in the world, just wanted to record it as I saw it. Thanks for the PR! |
Member
|
It works as expected. I can also confirm that this fixed the #35814 as well.
|
Mamaduka
approved these changes
Oct 21, 2021
Contributor
|
🚀 |
Contributor
Author
|
@vcanales this should be cherry picked for the stable 11.8. Thanks! |
vcanales
added
[Block] Navigation
vcanales
pushed a commit
that referenced
this pull request
Oct 21, 2021
fullofcaffeine
added a commit
that referenced
this pull request
Oct 21, 2021
* trunk: (494 commits) remove consecutive rc warning (#35855) Update Changelog for 11.8.0-rc.2 Bump plugin version to 11.8.0-rc.2 [RNMobile] Disable React Native E2E Tests (iOS) (#35844) Add section about using the schema during development (#35835) Add a method to disable auto-accepting dialogs (#35828) Wrap NavigationContainer with SafeAreaView. (#35570) Update Appium to 1.22.0 (#35829) Post Comment: Handle the case where a comment does not exist (#35810) Clear selected block when clicking on the gray background (#35816) Post excerpt: Don't print the wrapper when there is no excerpt (#35749) [Block] Navigation: Fix padding for social links on mobile (#35824) Fix issue with responsive navigation causing wrapping. (#35820) [Block Editor]: Fix displaying only `none` alignment option (#35822) Add API to access global settings, styles, and stylesheet (#34843) Mobile Release v1.64.1 (#35804) Add resizer to template part focus mode (#35728) Update Changelog for 11.7.1 Gallery block: Only show the gallery upload error message if mixed multiple files uploaded (#35790) Update Changelog for 11.8.0-rc.1 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #35341
Fixes: #35814
Recently a
nonealignment option was added along with some contextual info(when available) for the widths. There are use cases though in site editor where we would end up with theAlignmentControlcontaining only thenoneoption.Such use cases came from this PR that removed the alignments from the top level of the site editor because at that point there's no defined layout, as they won't do anything.
In my PR I also bring back the check in
alignhook not to render the toolbar item if there are no alignments available, which was added in above Riad's PR and then removed here ( I also had approved the PR and didn't get the reason for that being there).Testing instructions
noneoption.noneoption should be there as well.