-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Image Block: Add data-id attribute on server side render for core galleries #35975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b0cddec
Adding a server render_callback in order to add a data-id attribute t…
ramonjd a0b5948
Switch to using the_post instead of server side block render
6af28ef
Change order of attribs and check for innerBlocks
48975cd
Reinstating render_callback
ramonjd 15e8532
This commit adds a data-id attribute to every image innerblock of a g…
ramonjd fcd872f
NEWSFLASH! Array keys must be surrounded by spaces unless they cont…
ramonjd a958531
Adding a render function so that block based themes render the galler…
ramonjd ff4ba58
Add guards for undefined indexes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Adding a server render_callback in order to add a data-id attribute t…
…o the image element. Check for existing data-id attribute on the image block content Wrapping $attributes['id'] in an isset check to catch undefined indexes
- Loading branch information
commit b0cddec62f1079296de8a2cfed9e63ddc2edacc9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
| /** | ||
| * Server-side rendering of the `core/image` block. | ||
| * | ||
| * @package gutenberg | ||
| */ | ||
|
|
||
| /** | ||
| * Renders the `core/image` block on the server. | ||
| * | ||
| * @param array $attributes The block attributes. | ||
| * @param array $content The block content. | ||
| * @return string Returns the block content with the data-id attribute added. | ||
| */ | ||
| function render_block_core_image( $attributes, $content ) { | ||
| if ( isset( $attributes['id'] ) ) { | ||
| // Add the data-id="$id" attribute to the img element | ||
| // to provide backwards compatibility for the Gallery Block, | ||
| // which now wraps Image Blocks within innerBlocks. | ||
| $data_id_attribute = 'data-id="' . esc_attr( $attributes['id'] ) . '"'; | ||
| if ( ! strpos( $content, $data_id_attribute ) ) { | ||
| $content = str_replace( '<img', '<img ' . $data_id_attribute . ' ', $content ); | ||
| } | ||
| } | ||
| return $content; | ||
| } | ||
|
|
||
|
|
||
| /** | ||
| * Register image block. | ||
| */ | ||
| function register_block_core_image() { | ||
| register_block_type_from_metadata( | ||
| __DIR__ . '/image', | ||
| array( | ||
| 'render_callback' => 'render_block_core_image', | ||
| ) | ||
| ); | ||
| } | ||
| add_action( 'init', 'register_block_core_image' ); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.