Skip to content

LineHeightControl: Use __unstableSize prop in Typography panel #36196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mirka wants to merge 2 commits into from
Closed

LineHeightControl: Use __unstableSize prop in Typography panel #36196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3666dae
LineHeightControl: Add `__unstableSize="large"` variant
mirka Nov 4, 2021
2ea6c8e
Enable large size in Typography panels
mirka Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Enable large size in Typography panels
  • Loading branch information
@mirka
mirka committed Nov 4, 2021
commit 2ea6c8e49bcc6f5a83499751c72ff0df41f2d956
1 change: 1 addition & 0 deletions packages/block-editor/src/hooks/line-height.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ export function LineHeightEdit( props ) {
};
return (
<LineHeightControl
__unstableSize="large"
value={ style?.typography?.lineHeight }
onChange={ onChange }
/>
Expand Down
1 change: 1 addition & 0 deletions packages/components/src/tools-panel/stories/typography-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ export const TypographyPanel = () => {
isShownByDefault={ true }
>
<LineHeightControl
__unstableSize="large"
value={ lineHeight }
onChange={ setLineHeight }
/>
Expand Down
1 change: 1 addition & 0 deletions packages/edit-site/src/components/global-styles/typography-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ export default function TypographyPanel( { name } ) {
) }
{ hasLineHeightEnabled && (
<LineHeightControl
__unstableSize="large"
value={ lineHeight }
onChange={ setLineHeight }
/>
Expand Down