Babel Preset: Update Babel packages to 7.16 version #36244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Type] Enhancement
gziolo
requested review from
adamsilverstein,
adamziel,
ajitbohra,
atimmer,
cameronvoell,
dmsnell,
draganescu,
ellatrix,
getdave,
guarani,
kevin940726,
mmtr,
nerrad,
noisysocks,
ntwb,
oandregal,
swissspidy,
talldan and
tellthemachines
as code owners
|
Size Change: +6.83 kB (+1%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/babel-7.16-upgrade
branch
from
4e7706e to
5e60159
Compare
gziolo
added
[Tool] WP Scripts
Member
Author
|
@andrewserong and @adamziel - it would be great to land this PR as part of the Gutenberg 11.9 release so we propagate all the changes related to Babel to WordPress core. We can cherry-pick that later if you don't feel confident landing it today. The changes impact only the runtime code that Babel uses with all WordPress packages. |
Contributor
|
Thanks for the ping @gziolo, the RC has already gone out so this will need to be cherry-picked into the release once it lands. Will that be an issue with all the I've added this PR to the tracking issue for PRs that will need to be cherry picked for 11.9 in #36274 |
gziolo
removed request for
oandregal,
swissspidy,
talldan and
tellthemachines
andrewserong
added
the
Backport to WP 6.9 Beta/RC
Contributor
|
We're close to releasing GB 11.9, so I've updated the milestone on this PR to GB 12.0 and added the Backport to WP Beta/RC label. Once this lands in GB 12.0, I believe it should still be able to be cherry picked into WP 5.9? |
Member
Author
|
Gutenberg 11.9 is out so let’s give it a try. I don’t expect any issues since there were no CI issues. |
fluiddot
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Nov 12, 2021
This modification is required due to the update of Babel packages to 7.16 version in Gutenberg (PR reference: WordPress/gutenberg#36244).
fluiddot
added a commit
to wordpress-mobile/gutenberg-mobile
that referenced
this pull request
Nov 12, 2021
This modification is required due to the update of Babel packages to 7.16 version in Gutenberg (PR reference: WordPress/gutenberg#36244).
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Babel Preset: Update Babel packages to 7.16 version * Docs: Include changelog entries for Babel upgrade
7 tasks
ryelle
added a commit
to WordPress/pattern-directory
that referenced
this pull request
Nov 19, 2021
This avoids an issue with the babel update from WordPress/gutenberg#36244 where running `wp-scripts lint-js` causes an error for every file, "Parsing error: No Babel config file detected."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The announcement post from Babel for 7.16.0 release:
https://babeljs.io/blog/2021/10/29/7.16.0.html
This PR contains mostly updates to packages that Babel preset uses. It also includes some enforced changes to the ESLint presets that use now
@babel/eslint-parserinstead of the deprecatedbabel-eslint.Changes included
@wordpress/babel-preset-default@babel/coredependency has been updated from requiring^7.13.19to requiring^7.16.0.@babel/plugin-transform-react-jsxdependency has been updated from requiring^7.12.7to requiring `^7.16.0@babel/plugin-transform-runtimedependency has been updated from requiring^7.13.10to requiring^7.16.0.@babel/preset-envdependency has been updated from requiring^7.13.10to requiring^7.16.0.@babel/preset-typescriptdependency has been updated from requiring^7.13.10to requiring^7.16.0.@babel/runtimedependency has been updated from requiring^7.13.10to requiring^7.16.0.browserslistdependency has been updated from requiring^4.16.6to requiring^4.17.6.core-jsdependency has been updated from requiring^3.12.1to requiring^3.19.1.@wordpress/eslint-pluginbabel-eslintdependency with@babel/eslint-parser.eslint-plugin-importdependency has been updated from requiring^2.23.4to requiring^2.25.2.@wordpress/scriptsbrowserslistdependency has been updated from requiring^4.16.6to requiring^4.17.6.@wordpress/eslint-plugin.How has this been tested?
I executed the following commands locally:
npm run buildnpm run devnpm run lint-jsnpm run test-unitnpm run test-e2enpm run storybook:buildI also tested Create Block integration with
@wordpress/scripts:./bin/test-create-block.shTypes of changes
Update of the Babel packages.
Checklist:
*.native.jsfiles for terms that need renaming or removal).