Skip to content

core-data: use Object.fromEntries instead of reduce when generating entities reducer #36296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 1 commit into from
Aug 22, 2025
Merged

core-data: use Object.fromEntries instead of reduce when generating entities reducer #36296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 38 additions & 17 deletions packages/core-data/src/reducer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,29 @@ export function entitiesConfig( state = rootEntitiesConfig, action ) {
export const entities = ( state = {}, action ) => {
const newConfig = entitiesConfig( state.config, action );

// Generates a dynamic reducer for the entities.
// Generates a reducer for the entities nested by `kind` and `name`.
// A config array with shape:
// ```
// [
// { kind: 'taxonomy', name: 'category' },
// { kind: 'taxonomy', name: 'post_tag' },
// { kind: 'postType', name: 'post' },
// { kind: 'postType', name: 'page' },
// ]
// ```
// generates a reducer for state tree with shape:
// ```
// {
// taxonomy: {
// category,
// post_tag,
// },
// postType: {
// post,
// page,
// },
// }
// ```
let entitiesDataReducer = state.reducer;
if ( ! entitiesDataReducer || newConfig !== state.config ) {
const entitiesByKind = newConfig.reduce( ( acc, record ) => {
Expand All @@ -431,22 +453,21 @@ export const entities = ( state = {}, action ) => {
}, {} );

entitiesDataReducer = combineReducers(
Object.entries( entitiesByKind ).reduce(
( memo, [ kind, subEntities ] ) => {
const kindReducer = combineReducers(
subEntities.reduce(
( kindMemo, entityConfig ) => ( {
...kindMemo,
[ entityConfig.name ]: entity( entityConfig ),
} ),
{}
)
);

memo[ kind ] = kindReducer;
return memo;
},
{}
Object.fromEntries(
Object.entries( entitiesByKind ).map(
( [ kind, subEntities ] ) => {
const kindReducer = combineReducers(
Object.fromEntries(
subEntities.map( ( entityConfig ) => [
entityConfig.name,
entity( entityConfig ),
] )
)
);

return [ kind, kindReducer ];
}
)
)
);
}
Expand Down
Loading