Navigation: Skip text decoration support serialization and apply as CSS class #36345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Block] Navigation
|
Size Change: +254 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
842ed79 to
9232704
Compare
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
from
d7d4d81 to
fc2cb54
Compare
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
9232704 to
5a7823d
Compare
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
2 times, most recently
from
cffa9f6 to
36e7109
Compare
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
5a7823d to
4fb3744
Compare
7 tasks
8 tasks
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
from
36e7109 to
9865b77
Compare
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
4fb3744 to
635e4e0
Compare
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
from
9865b77 to
9d957b0
Compare
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
from
9d957b0 to
f192859
Compare
ramonjd
force-pushed
the
try/skip-individual-feature-serialization
branch
5 times, most recently
from
99e107f to
0f1ea45
Compare
ramonjd
force-pushed
the
try/skip-individual-feature-serialization
branch
3 times, most recently
from
af420ab to
4bf4fd7
Compare
aaronrobertshaw
force-pushed
the
try/skip-individual-feature-serialization
branch
from
fa4a95c to
aa0e91d
Compare
Base automatically changed from
try/skip-individual-feature-serialization
to
trunk
March 29, 2022 00:51
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
635e4e0 to
f3666c8
Compare
aaronrobertshaw
changed the title
tellthemachines
approved these changes
Mar 29, 2022
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this 🎉 Code looks good and works well in testing:
- styles apply to both navigation and page list links;
- styles don't apply to social icons or search text.
aaronrobertshaw
force-pushed
the
update/navigation-manually-apply-text-decoration
branch
from
f3666c8 to
ffebcb3
Compare
aaronrobertshaw
deleted the
update/navigation-manually-apply-text-decoration
branch
Contributor
|
Nice one! |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34275
Related:
(Original PR before individual support serialization could be skipped)
Description
This PR reinstates the Navigation block's opt-in to using the text-decoration block support.
Rather than rely on the default inline style application of the block support value, the navigation block instead skips the serialization of only the text-decoration style (courtesy of #36293) and applies the decoration via a new CSS class.
How has this been tested?
Screenshots
Types of changes
Enhancement / Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).