Skip to content

Strip meta tags from pasted links in Chromium #36356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
getdave merged 3 commits into from
Nov 11, 2021
Merged

Strip meta tags from pasted links in Chromium #36356

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de871c7
Strip meta tag
getdave Nov 9, 2021
520a4b8
Corrections for accuracy
getdave Nov 9, 2021
62bb136
Simply by avoiding regex
getdave Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/block-editor/src/components/rich-text/use-paste-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,9 @@ export function usePasteHandler( props ) {
// Remove Windows-specific metadata appended within copied HTML text.
html = removeWindowsFragments( html );

// Strip meta tag.
html = removeCharsetMetaTag( html );

event.preventDefault();

// Allows us to ask for this information when we get a report.
Expand Down Expand Up @@ -257,3 +260,22 @@ function removeWindowsFragments( html ) {

return html.replace( startReg, '' ).replace( endReg, '' );
}

/**
* Removes the charset meta tag inserted by Chromium.
* See:
* - https://github.com/WordPress/gutenberg/issues/33585
* - https://bugs.chromium.org/p/chromium/issues/detail?id=1264616#c4
*
* @param {string} html the html to be stripped of the meta tag.
* @return {string} the cleaned html
*/
function removeCharsetMetaTag( html ) {
const metaTag = `<meta charset='utf-8'>`;

if ( html.startsWith( metaTag ) ) {
return html.slice( metaTag.length );
}

return html;
}