Nav block menu switcher - decode HTML entities and utilise accessible markup pattern #36397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
the
Backport to WP 6.9 Beta/RC
|
Size Change: +54 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 15, 2021
… markup pattern (#36397) * Decode HTML entities and utilise accessible markup pattern * Fix placeholder instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when you click
Select Menuon a Nav block the menu names are not decoded in multiple places which means you may see entities in the rendered output.This PR decodes the title and also applies a more accessible markup pattern.
How has this been tested?
Dave's & Entity Menu).Select Menuwithin the placeholder.Select Menuon block toolbar.trunkwhere this doesn't happen and you can see entities.Screenshots
Types of changes
Checklist:
*.native.jsfiles for terms that need renaming or removal).