Skip to content

Cover Block: Fix regressions #36406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 10 commits into from
Nov 16, 2021
Merged

Cover Block: Fix regressions #36406

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3f7f10e
Restore styles for old markup
WunderBart Nov 11, 2021
176a0f3
Set default dim to 50% for media and 100% for solids
WunderBart Nov 11, 2021
42883f5
Fix transition from Image
WunderBart Nov 11, 2021
ee4aee0
Regenerate fixtures
WunderBart Nov 11, 2021
6a8348e
Remove default dim ratio as it's derived from attributes
WunderBart Nov 11, 2021
1717838
Regenerate fixtures again
WunderBart Nov 11, 2021
1877be3
Add e2e test for dimmed background when transformed from Image
WunderBart Nov 11, 2021
025c7f1
Switch to using 'url' to detect if dimRatio should be 50 instead of u…
Nov 15, 2021
65b5290
Set the default dimRatio in the transformation instead of changing at…
Nov 15, 2021
173e983
Linting fix
Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Regenerate fixtures again
  • Loading branch information
@WunderBart
WunderBart committed Nov 11, 2021
commit 171783838a30f83e3abee29d4275955fe8ccbdf1
2 changes: 1 addition & 1 deletion test/integration/fixtures/blocks/core__cover__gradient.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:cover {"customGradient":"linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"} -->
<!-- wp:cover {"dimRatio":100,"customGradient":"linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"} -->
<div class="wp-block-cover">
<span aria-hidden="true" class="has-background-dim-100 wp-block-cover__gradient-background has-background-dim has-background-gradient" style="background:linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"></span>
<div class="wp-block-cover__inner-container">
Expand Down
1 change: 1 addition & 0 deletions test/integration/fixtures/blocks/core__cover__gradient.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
"blockName": "core/cover",
"attrs": {
"dimRatio": 100,
"customGradient": "linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"
},
"innerBlocks": [
Expand Down
2 changes: 1 addition & 1 deletion test/integration/fixtures/blocks/core__cover__gradient.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:cover {"customGradient":"linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"} -->
<!-- wp:cover {"dimRatio":100,"customGradient":"linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"} -->
<div class="wp-block-cover"><span aria-hidden="true" class="has-background-dim-100 wp-block-cover__gradient-background has-background-dim has-background-gradient" style="background:linear-gradient(135deg,rgb(255,203,112) 0%,rgb(199,81,192) 50%,rgb(65,88,208) 100%)"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…","fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size">Cover!</p>
<!-- /wp:paragraph --></div></div>
Expand Down
2 changes: 1 addition & 1 deletion test/integration/fixtures/blocks/core__cover__solid-color.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:cover {"overlayColor":"primary"} -->
<!-- wp:cover {"dimRatio":100,"overlayColor":"primary"} -->
<div class="wp-block-cover">
<span aria-hidden="true" class="has-primary-background-color has-background-dim-100 wp-block-cover__gradient-background has-background-dim"></span>
<div class="wp-block-cover__inner-container">
Expand Down
1 change: 1 addition & 0 deletions test/integration/fixtures/blocks/core__cover__solid-color.parsed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{
"blockName": "core/cover",
"attrs": {
"dimRatio": 100,
"overlayColor": "primary"
},
"innerBlocks": [
Expand Down
2 changes: 1 addition & 1 deletion test/integration/fixtures/blocks/core__cover__solid-color.serialized.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!-- wp:cover {"overlayColor":"primary"} -->
<!-- wp:cover {"dimRatio":100,"overlayColor":"primary"} -->
<div class="wp-block-cover"><span aria-hidden="true" class="has-primary-background-color has-background-dim-100 wp-block-cover__gradient-background has-background-dim"></span><div class="wp-block-cover__inner-container"><!-- wp:paragraph {"align":"center","placeholder":"Write title…","fontSize":"large"} -->
<p class="has-text-align-center has-large-font-size"></p>
<!-- /wp:paragraph --></div></div>
Expand Down