Skip to content

Change @package to WordPress in block-library #36494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Mamaduka merged 1 commit into from
Nov 16, 2021
Merged

Change @package to WordPress in block-library #36494

Mamaduka merged 1 commit into from
Nov 16, 2021

Conversation

@walbo
Copy link
Member

@walbo walbo commented Nov 15, 2021 •
edited
Loading

Description

Renames @package gutenberg to @package WordPress in block-library php files. These files are copied to core and should use WordPress.

Related:
#12085, #12319

Types of changes

Change in comments, no code or functional change

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@walbo walbo added the [Type] Code Quality Issues or PRs that relate to code quality label Nov 15, 2021
Mamaduka
Mamaduka approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Thanks, @walbo.

ajitbohra
ajitbohra approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@ajitbohra ajitbohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Mamaduka Mamaduka added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 16, 2021
@Mamaduka Mamaduka merged commit 2d23fcd into trunk Nov 16, 2021
@Mamaduka Mamaduka deleted the update/package-wordpress-in-block-library branch November 16, 2021 10:49
@github-actions github-actions bot added this to the Gutenberg 12.0 milestone Nov 16, 2021
@gziolo
Copy link
Member

gziolo commented Nov 19, 2021

Good catch, thank you 👍

@noisysocks noisysocks removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Nov 22, 2021
noisysocks pushed a commit that referenced this pull request Nov 22, 2021
@noisysocks
Change @Package to WordPress in block-library (#36494)
2069d76
@noisysocks noisysocks mentioned this pull request Nov 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mamaduka Mamaduka Mamaduka approved these changes

@ajitbohra ajitbohra ajitbohra approved these changes

@mkevins mkevins Awaiting requested review from mkevins

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

Assignees

No one assigned

Labels

[Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Milestone

Gutenberg 12.0

Development

Successfully merging this pull request may close these issues.

6 participants

@walbo @gziolo @Mamaduka @ajitbohra @noisysocks