Skip to content

Conversation

@glendaviesnz
Copy link
Contributor

@glendaviesnz glendaviesnz commented Nov 16, 2021

Description

There have been issues with getting auto migration of v1 gallery blocks stabilised for the 5.9 release so this PR disables the v2 Gallery block. If the decision is made to pull the v2 Gallery block from 5.9 then this PR would be merged and cherry picked to 5.9 and then this commit would be reverted on trunk so the v2 Gallery blocks are still available in the plugin.

Important If this is cherry picked into 5.9 it is critical that WordPress/wordpress-develop#1678 is also included.

Once this is cherry picked to 5.9 this flag should be updated on trunk to disabled the option for sites where use_balanceTags is set.

How has this been tested?

  • Revert to a gutenberg plugin <= 11.7 with gallery experiment turned off and add some gallery blocks
  • Check out this PR to a local dev env
  • Reload the previous added galleries and make sure they stay in v1 format. They will have move icons in the image as in the first screenshot and nested images in a <ul> structure rather than nested image blocks.
  • Add a Gallery block and make sure it is the v2 format - it will have nested individual image blocks, and each image will have its own block toolbar like the second screenshot below.
  • Make sure when refreshing the editor the two different types of blocks stay in the correct format
  • Try clicking the Update button in the block toolbar of a v1 Gallery block and check that it converts to a v2 Gallery block successfully

Screenshots

v1 Gallery block
Screen Shot 2021-11-16 at 9 50 57 PM

V2 Gallery block
Screen Shot 2021-11-16 at 9 58 45 PM

@glendaviesnz glendaviesnz added the [Block] Gallery Affects the Gallery Block - used to display groups of images label Nov 16, 2021
@glendaviesnz glendaviesnz self-assigned this Nov 16, 2021
@ocean90
Copy link
Member

ocean90 commented Dec 5, 2021

@glendaviesnz I think the description of this PR is wrong and was meant for #36508?

@glendaviesnz
Copy link
Contributor Author

@ocean90 this PR was superseded by #36191, so closing

@johnbillion johnbillion deleted the update/gallery-block-enable-for-5-9 branch April 22, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Gallery Affects the Gallery Block - used to display groups of images

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants