Navigation: Scale submenu icon. #36714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Bug
|
Size Change: +50 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
|
Nice! Small nuance related to your notes on how to approach the icon: purely based on the animation above, perhaps the larger scaled text doesn't need that arrow size. The arrow can stay at 18 or 24 when the type is 32, if possible. Right now it looks a bit too large of an icon:
I guess this case is equally applicable in the context of opened submenu overlay. |
Contributor
Author
|
Thanks for the notes! My first instinct to try was to add a max-width/height to the icon, so that the icon is never larger than, say, 24px width/height pixels. In my testing this didn't work that well, and introduced some complexity around vertically centering the icon. It gets a bit technical with pixel rounding and such, and ultimately I felt it worked better to not apply those limits. Instead I tried reducing the size of the icon from 80% to 60%, and I think that works well: |
Member
|
Thanks, looks good to me. Not sure if there are any concerns from a themes perspective cc @kjellr |
mtias
approved these changes
Nov 22, 2021
Contributor
|
This looks good! In the longterm if might be nice for themes to be able to adjust the thickness of the icon to match their typeface's weight more closely. But that's a nice-to-have. |
Contributor
Author
I'd love to see a good interface for generally configuring icons and their behavior, not just for this dropdown, but for the burger icon, the close icon, all those things. |
jasmussen
added
the
Backport to WP 6.9 Beta/RC
|
Allowing custom icons makes sense, but the alignment of the icon with the font style could and probably should just work as recommended. |
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Nov 23, 2021
* Navigation: Scale submenu icon. * Update icon to be 60% size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #36700. Updates the submenu icon to scale according to the font size applied. Before:
After:
Note, the above sets the dimensions of the icon to 0.8em (80% of the font size), which feels like a right balance. But that does occasionally render the icon at subpixel integers. Visually I think that's acceptable for the icon. But we can also set the dimensions to 1em:
A third option is to set the dimensions to 1em, but scale down the icon inside the SVG. All of these should be easy, so would be happy to address per feedback.
How has this been tested?
Insert a navigation block with submenus and change the font size.
Checklist:
*.native.jsfiles for terms that need renaming or removal).