-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Use first non-empty Nav post as primary fallback for Nav block #36740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
33995bc
Use non-empty Nav post as fallback
getdave 3a4e549
Remove code duplication
getdave 098f453
Extract finding non empty nav block to function
getdave d466c2b
Extract process of getting fallback to dedicated function
getdave 5e75bb5
Apply block prefix to functions
getdave d952588
Add additional safety check around parsing Nav blocks
getdave d15df93
Extract function for removing null blocks and apply
getdave cdaaf5e
Check for empty parsed Nav blocks
getdave d6d1e25
Improve function comment
getdave 2831ff3
Amend ordering params to approximate current wp_nav_menus behaviour
getdave 5f8263b
Fetch Nav posts in query rather than filtering in memory
getdave 7ff837e
Improve comments
getdave 81bf76a
Spacing
getdave ead6d3c
Limit Nav Posts query to a single item
getdave b0c80aa
Fix linting
getdave 4dbb220
Improve function naming
getdave File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Use non-empty Nav post as fallback
- Loading branch information
commit 33995bc4385539db61af66b4ac64aa3aeb2af1d5
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.