Skip to content

Gallery: Fix stuck image size options loader #36806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 1 commit into from
Nov 24, 2021
Merged

Gallery: Fix stuck image size options loader #36806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Gallery: Fix stuck image size options loader
  • Loading branch information
@andrewserong
andrewserong committed Nov 24, 2021
commit 455a98a25241412fd219654814ab5976b63a3ff1
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ function GalleryEdit( props ) {
hideCancelButton={ true }
/>
) }
{ Platform.isWeb && ! imageSizeOptions && (
{ Platform.isWeb && ! imageSizeOptions && hasImageIds && (
<BaseControl className={ 'gallery-image-sizes' }>
<BaseControl.VisualLabel>
{ __( 'Image size' ) }
Expand Down
2 changes: 1 addition & 1 deletion packages/block-library/src/gallery/v1/update-gallery-modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const updateGallery = ( {
}
const innerBlocks = images.map( ( image ) =>
createBlock( 'core/image', {
id: parseInt( image.id, 10 ),
id: image.id ? parseInt( image.id, 10 ) : null,
url: image.url,
alt: image.alt,
caption: image.caption,
Expand Down