Update micromodal, include click-through fix #36837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcanales
added
[Type] Bug
|
Size Change: +48 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
vcanales
changed the title
jasmussen
requested review from
a team,
gwwar and
ockham
and removed request for
a team
gziolo
reviewed
Nov 25, 2021
vcanales
force-pushed
the
deps/update-micromodal
branch
3 times, most recently
from
a325297 to
60e574c
Compare
Contributor
|
Adding this to the 5.9 must-haves because it would be good to get this fix in. |
tellthemachines
added
the
Backport to WP 6.9 Beta/RC
gziolo
reviewed
Nov 29, 2021
| @@ -22019,16 +22019,6 @@ | |||
| "yauzl": "^2.7.0" | |||
| }, | |||
| "dependencies": { | |||
Member
There was a problem hiding this comment.
See the failing CI job: https://github.com/WordPress/gutenberg/runs/4336043229?check_suite_focus=true.
Suggested change
| "dependencies": { | |
| "dependencies": { | |
| "are-we-there-yet": { | |
| "version": "2.0.0", | |
| "resolved": "https://registry.npmjs.org/are-we-there-yet/-/are-we-there-yet-2.0.0.tgz", | |
| "integrity": "sha512-Ci/qENmwHnsYo9xKIcUJN5LeDKdJ6R1Z1j9V/J5wyq8nh/mYPEpIKJbBZXtZjG04HiK7zV/p6Vs9952MrMeUIw==", | |
| "dev": true, | |
| "requires": { | |
| "delegates": "^1.0.0", | |
| "readable-stream": "^3.6.0" | |
| } | |
| }, |
gziolo
approved these changes
Nov 29, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
The package lock file needs a small tweak. There is some strange issue with npm happening. I see this package are-we-there-yet getting removed and added back too many times 😞
Member
If you |
Member
Author
|
Unit and e2e test failures seen here are present in trunk, and the test failure related to |
vcanales
force-pushed
the
deps/update-micromodal
branch
3 times, most recently
from
0d8e253 to
f2665b6
Compare
Member
Author
Related or not, I can't merge this with those tests failing; I'd appreciate your help with that @gziolo :) |
vcanales
force-pushed
the
deps/update-micromodal
branch
from
f2665b6 to
b2841f8
Compare
noisysocks
force-pushed
the
deps/update-micromodal
branch
from
b2841f8 to
35899ff
Compare
Member
|
I rebased this to (hopefully) fix failing tests. |
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 6, 2021
Member
Author
|
@gziolo @noisysocks thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #31957
A
touchstartevent bug on MicroModal was causing the close button to click the avatar button on the admin bar.Tested on Firefox and Safari, and it seems to work correctly now.
How has this been tested?
Screenshots