Skip to content

Use core version of template and template part post types and REST endpoints for WP 5.9, with back compat for 5.8 #36898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
talldan merged 9 commits into from
Dec 2, 2021
Merged

Use core version of template and template part post types and REST endpoints for WP 5.9, with back compat for 5.8 #36898

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f6b3861
Use core version of template and template part post types and REST en…
talldan Nov 25, 2021
d818541
Move files and add explanation
talldan Dec 1, 2021
85f2cf7
Only register gutenberg version of templates and template parts when …
talldan Dec 1, 2021
d210a6c
Rename WP_Block_Template to Gutenberg_Block_Template so that 5.8 rece…
talldan Dec 1, 2021
7452819
Load moved files
talldan Dec 1, 2021
b48f643
Update references and sync some code
talldan Dec 1, 2021
fbf6265
Fix filename
talldan Dec 1, 2021
6d15485
Remove templates tests since Gutenberg now defaults to using the WP c…
talldan Dec 1, 2021
293a96a
Linting and test fixes
talldan Dec 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename WP_Block_Template to Gutenberg_Block_Template so that 5.8 rece… 
…ives improvements to it
  • Loading branch information
@talldan
talldan committed Dec 1, 2021
commit d210a6c5cc5004f0d5a680ac48fb22aee3caf1a2
4 changes: 2 additions & 2 deletions ...-site-editing/class-wp-block-template.php → ...ss-5.9/class-gutenberg-block-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/**
* Blocks API: WP_Block_Template class
* Blocks API: Gutenberg_Block_Template class
*
* @package WordPress
* @since 5.5.0
Expand All @@ -9,7 +9,7 @@
/**
* Class representing a block template.
*/
class WP_Block_Template {
class Gutenberg_Block_Template {
Copy link
Contributor Author

@talldan talldan Dec 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've renamed this and the situation should be:

  • If Gutenberg is running on WordPress 5.8, Gutenberg_Block_Template is used instead of WP_Block_Template`, since the latter is outdated in 5.8.
  • If Gutenberg is running on WordPress 5.9, WP_Block_Template is used.

This should resolve any issues where author or origin might not be defined on 5.8.


/**
* Type: wp_template or wp_template_part
Expand Down