Skip to content

Color Picker: Re-instate debounce and controlled value to fix issue with gradient picker #36941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewserong merged 3 commits into from
Nov 30, 2021
Merged

Color Picker: Re-instate debounce and controlled value to fix issue with gradient picker #36941

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e0d22d
Color Picker: Re-instate debounce and controlled value to fix issue w…
andrewserong Nov 29, 2021
c4c051a
Add changelog, update readme, simplify safeColordColor return value
andrewserong Nov 30, 2021
5f96fc8
Remove defaultValue from useMemo dependency array since it is no long…
andrewserong Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove defaultValue from useMemo dependency array since it is no long… 
…er used in the useMemo
  • Loading branch information
@andrewserong
andrewserong committed Nov 30, 2021
commit 5f96fc8ce8b587297a6b47795ae654835ed91b68
2 changes: 1 addition & 1 deletion packages/components/src/color-picker/component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const ColorPicker = (

const safeColordColor = useMemo( () => {
return colord( color );
}, [ color, defaultValue ] );
}, [ color ] );

const debouncedSetColor = useDebounce( setColor );

Expand Down