Skip to content

E2E Tests: Fix failing image e2e test by waiting for required element #36982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glendaviesnz merged 9 commits into from
Nov 30, 2021
Merged

E2E Tests: Fix failing image e2e test by waiting for required element #36982

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
94e57b9
Fix failing image e2e test by waiting for required element before att…
Nov 29, 2021
d751803
Reinstate skipped e2e test - make more reliable by waiting for resize…
Nov 29, 2021
094819e
Switch to waiting for image instead of the image resize buttons
Nov 30, 2021
b99e628
Add back the wait for the image resize buttons
Nov 30, 2021
a729d69
Skip mentions test until password error in core WP 5.9 is fixed
Nov 30, 2021
cdfd9db
Add delay when clearing input field and typing replacement url
andrewserong Nov 30, 2021
0436e24
Re-enable autocomplete tests
talldan Nov 30, 2021
1902936
Add in wait for user input box to prevent username being partially en…
Nov 30, 2021
fe62f05
Add phpunit-polyfills to fix running of php-unit tests locally
Nov 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reinstate skipped e2e test - make more reliable by waiting for resize… 
… buttons, and by clicking image block wrapper to delete block
  • Loading branch information
Glen Davies committed Nov 30, 2021
commit d751803dcde28f78bafad3b25a025b9ac506398a
8 changes: 6 additions & 2 deletions packages/e2e-tests/specs/editor/blocks/image.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe( 'Image', () => {
expect( await getEditedPostContent() ).toMatch( regex );
} );

it.skip( 'should replace, reset size, and keep selection', async () => {
it( 'should replace, reset size, and keep selection', async () => {
await insertBlock( 'Image' );
const filename1 = await upload( '.wp-block-image input[type="file"]' );
await waitForImage( filename1 );
Expand All @@ -85,6 +85,10 @@ describe( 'Image', () => {
expect( await getEditedPostContent() ).toMatch( regex1 );

await openDocumentSettingsSidebar();
await page.waitForSelector(
'[aria-label="Image size presets"] button:first-child',
{ visible: true }
);
await page.click( '[aria-label="Image size presets"] button' );

const regex2 = new RegExp(
Expand All @@ -104,7 +108,7 @@ describe( 'Image', () => {
);
expect( await getEditedPostContent() ).toMatch( regex3 );

await page.click( '.wp-block-image img' );
await page.click( '.wp-block-image' );
await page.keyboard.press( 'Backspace' );

expect( await getEditedPostContent() ).toBe( '' );
Expand Down