Tests: Specify PHP version in composer #37007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
approved these changes
Nov 30, 2021
noahtallen
approved these changes
Nov 30, 2021
Member
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
LGTM! Verified that npm run prelint-php (which handles composer install) currently fails on trunk locally, and this branch makes it work.
7 tasks
Member
|
Hi, @walbo Can you rebase, and we can merge this? Thanks |
ockham
force-pushed
the
try/composer-platform-php-version
branch
from
d62e5dc to
50e2ab8
Compare
noahtallen
force-pushed
the
try/composer-platform-php-version
branch
from
50e2ab8 to
39a3cf2
Compare
Member
|
The test failure in this branch appears to be happening on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Specify that the composer image should use php 7.4
How has this been tested?
Unit tests should pass.
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).