[Block Library - Navigation]: Fix vertical layout #37009
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #36902
This PR fixes a regression introduced here: #36292.
Testing instructions
Navigationblock and add a couple of itemslayoutorientation tovertical(do not change content justification)verticalnowIn general I think something like this should be used to get the
defaultblock layout ineditfunction. Now in Navigation block we provide some layout defaults which seems that it shouldn't - I haven't checked in depth yet as the block itself is really convoluted.The specific problem was that we needed the
--layout-directionattribute which wasn't added iflayout.justifyContentwas empty.The logic about
setCascadingPropertiesneeds more looking. I noticed the 'spread' of items in vertical orientation (Search in Navigation, Social Links) and I believe there must be similar css rules like this fix.Screen.Recording.2021-11-30.at.8.39.43.PM.mov