Skip to content

[Block Library]: Rename Query Pagination blocks #37091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ntsekouras merged 2 commits into from
Dec 3, 2021
Merged

[Block Library]: Rename Query Pagination blocks #37091

ntsekouras merged 2 commits into from
Dec 3, 2021

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Dec 3, 2021 •
edited
Loading

Resolves: #37079

The Query Loop block's inner blocks all include the Query prefix in their names, making them sound more complex than they actually are.

This PR just renames these blocks to be more user-friendly, like Pagination Numbers instead of Query pagination numbers, as they are only surfaced within a Query Loop context.

I updated only the title of the blocks, making everything else work as before.

@ntsekouras ntsekouras added [Package] Block library /packages/block-library [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block labels Dec 3, 2021
@ntsekouras ntsekouras self-assigned this Dec 3, 2021
@ntsekouras ntsekouras requested a review from ajitbohra as a code owner December 3, 2021 09:43
mtias
mtias reviewed Dec 3, 2021
View reviewed changes
mtias
mtias reviewed Dec 3, 2021
View reviewed changes
mtias
mtias reviewed Dec 3, 2021
View reviewed changes
@ntsekouras ntsekouras merged commit 8131b76 into trunk Dec 3, 2021
@ntsekouras ntsekouras deleted the rename/query-pagination-blocks branch December 3, 2021 13:01
@ntsekouras
Copy link
Contributor Author

ntsekouras commented Dec 3, 2021

Is this something we want to backport for 5.9?

@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 3, 2021
@mtias mtias added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 3, 2021
@mtias
Copy link
Member

mtias commented Dec 3, 2021

Yes, it's a small copy change

@mtias mtias added the [Type] Copy Issues or PRs that need copy editing assistance label Dec 3, 2021
@noisysocks noisysocks removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 6, 2021
noisysocks pushed a commit that referenced this pull request Dec 6, 2021
@ntsekouras @mtias @noisysocks
[Block Library]: Rename Query Pagination blocks (#37091)
5ffd49c 
* [Block Library]: Rename Query Pagination blocks

* Apply suggestions from code review

Co-authored-by: Matias Ventura <[email protected]>

Co-authored-by: Matias Ventura <[email protected]>
@noisysocks noisysocks mentioned this pull request Dec 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtias mtias mtias approved these changes

@priethor priethor priethor approved these changes

@gziolo gziolo Awaiting requested review from gziolo

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@ntsekouras ntsekouras

Labels

[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Package] Block library /packages/block-library [Type] Copy Issues or PRs that need copy editing assistance

Projects

None yet

Milestone

Gutenberg 12.2

Development

Successfully merging this pull request may close these issues.

Rename Query- inner blocks to be more user-friendly

5 participants

@ntsekouras @mtias @priethor @noisysocks