Skip to content

Gallery block: enable the new gallery block by default if running in core #37134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 2 commits into from
Dec 6, 2021
Merged

Gallery block: enable the new gallery block by default if running in core #37134

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958dae8
Enable the new gallery block by default if running in core and not pl…
Dec 5, 2021
9f780a7
Add explanatory comment
Dec 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/block-library/src/gallery/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,19 @@ export const pickRelevantMediaFiles = ( image, sizeSlug = 'large' ) => {
* can be removed when minimum supported WP version >=5.9.
*/
export function isGalleryV2Enabled() {
// We want to fail early here, at least during beta testing phase, to ensure
// there aren't instances where undefined values cause false negatives.
if ( ! window.wp || typeof window.wp.galleryBlockV2Enabled !== 'boolean' ) {
throw 'window.wp.galleryBlockV2Enabled is not defined';
// Only run the Gallery version compat check if the plugin is running, otherwise
// assume we are in 5.9 core and enable by default.
if ( process.env.GUTENBERG_PHASE === 2 ) {
// We want to fail early here, at least during beta testing phase, to ensure
// there aren't instances where undefined values cause false negatives.
if (
! window.wp ||
typeof window.wp.galleryBlockV2Enabled !== 'boolean'
) {
throw 'window.wp.galleryBlockV2Enabled is not defined';
}
return window.wp.galleryBlockV2Enabled;
}

return window.wp.galleryBlockV2Enabled;
return true;
}