Switch to addEventListener for load event in the navigation block view script #37135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
Contributor
Author
|
Not a 'must have', but I think it's very low risk and minimal, so might as well include it in 5.9. |
|
Size Change: +2 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
Dec 6, 2021
Contributor
jasmussen
left a comment
jasmussen
left a comment
There was a problem hiding this comment.
Thank you, tests well:
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #35768.
As detailed in that issue, the navigation block's view script currently uses
window.onloadto initiate its client side code. The downside it that can override any other callback function already assigned to that property (in this situation it broke another plugin that also usesonload).This is a pretty simple change that instead uses
addEventListenerto make sure multiple event handlers can use the load event.How has this been tested?
Overlay Menu
Clicky submenus
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist:
*.native.jsfiles for terms that need renaming or removal).