Global Styles: Add Welcome Guide toggle #37180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Enhancement
|
Size Change: -9 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Dec 7, 2021
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Thanks for the PR George!
I think some changes will be needed here as well: https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-site/src/components/welcome-guide/index.js#L14, no ? 🤔
You can see in my recording when we select the global styles and then click welcome guide once (store update for feature) the guide is not rendered but if we click back to settings it's rendered then.
Screen.Recording.2021-12-07.at.2.49.22.PM.mov
Member
Author
|
Great catch, Nik. The issue should be fixed now. |
Mamaduka
force-pushed
the
add/welcome-guide-styles-more-menu
branch
from
6c28d76 to
f7780a2
Compare
Member
Author
|
@noisysocks, this got recently punted from the 5.9 Must-Haves list. Should we add it back? |
ntsekouras
approved these changes
Dec 8, 2021
Contributor
ntsekouras
left a comment
ntsekouras
left a comment
There was a problem hiding this comment.
Looks good, thanks George! 💯
Member
|
I punted everything with the enhancement label. Looks small though, let's add the backport label. |
noisysocks
added
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
* Global Styles: Add Welcome Guide toggle * Check isActive state locally in components
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR adds the Welcome Guide toggle button to the "More Global Styles Actions" dropdown.
Resolves #36544
How has this been tested?
Screenshots
Types of changes
Enhancement
Checklist:
*.native.jsfiles for terms that need renaming or removal).