Skip to content

Site Editor: Hide the block appender in the Template Part editor #37213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
noisysocks merged 1 commit into from
Dec 8, 2021
Merged

Site Editor: Hide the block appender in the Template Part editor #37213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Site Editor: Hide the block appender in the Template Part editor
  • Loading branch information
@noisysocks
noisysocks committed Dec 8, 2021
commit 75fac775131c2c316a736cbc5aa67dad60964233
1 change: 1 addition & 0 deletions packages/edit-site/src/components/block-editor/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@ export default function BlockEditor( { setIsInserterOpen } ) {
<BlockList
className="edit-site-block-editor__block-list wp-site-blocks"
__experimentalLayout={ LAYOUT }
renderAppender={ isTemplatePart ? false : undefined }
Copy link
Member

@kevin940726 kevin940726 Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still render the appender if the template is empty? As stated in the original issue's title.

Copy link
Contributor

@jameskoster jameskoster Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove all blocks, the default empty paragraph prompt appears:

Screenshot 2021-12-08 at 09 53 57

This probably warrants some design exploration (it might be good to surface patterns more prominently here), and shouldn't hold up this PR.

Copy link
Member Author

@noisysocks noisysocks Dec 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the paragraph appender will still appear. Agree it could use some love 🙂

Copy link
Contributor

@jameskoster jameskoster Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can address that as a part of #28737, and this probably elevates the importance of looking in to that issue for 6.0.

/>
</ResizableEditor>

Expand Down