Skip to content

Navigator: add basic history support, enable advanced focus restoration #37223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ciampo wants to merge 17 commits into from
Closed

Navigator: add basic history support, enable advanced focus restoration #37223

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d700ffe
`Navigator`: add basic history support
ciampo Dec 3, 2021
96f1d5f
Update Navigator usage across the repo
ciampo Dec 8, 2021
533e61f
Typo
ciampo Dec 8, 2021
092acf5
Rename `navigationTriggerElement` to `focusRestorationSelector`
ciampo Dec 8, 2021
7f8339f
Add focus restoration on navigating back
ciampo Dec 9, 2021
7b86743
Update Navigator stories to work with focus restoration
ciampo Dec 9, 2021
1a773b9
Add focus restoration support to Preferences Modal and GLobal Styles …
ciampo Dec 9, 2021
c78e792
Add `isInitial` property to the `location` object, use it instead of …
ciampo Dec 14, 2021
af8a6dd
Wrap `push` and `pop` in `useCallback`
ciampo Dec 14, 2021
94eb58c
Rename `focusRestorationSelector` to `focusTargetSelector`
ciampo Dec 14, 2021
3af4385
Make sure that `isInitial` and `isBack` cannot be overridden when pus…
ciampo Dec 14, 2021
ba08a42
Add `NavigatorLink` and `NavigatorBackLink`, replace usages across co…
ciampo Dec 14, 2021
76e88c6
Use `id` as the attribute to restore focus
ciampo Dec 14, 2021
8915a7c
Add `NavigatorLink` and `NavigatorBackLink` to docs manifest
ciampo Dec 14, 2021
38c4ed2
Refactor to hooks
ciampo Dec 15, 2021
df584de
Do not expose `selectorFactor` prop
ciampo Dec 15, 2021
d219320
Use `Button` as detault component to render `NavigatorLink` and `Navi…
ciampo Dec 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add NavigatorLink and NavigatorBackLink to docs manifest
  • Loading branch information
@ciampo
ciampo committed Dec 14, 2021
commit 8915a7c4ebff58c3919a76cfa40aa5b7ef8e1478
12 changes: 12 additions & 0 deletions docs/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1043,6 +1043,18 @@
"markdown_source": "../packages/components/src/navigation/README.md",
"parent": "components"
},
{
"title": "NavigatorBackLink",
"slug": "navigator-back-link",
"markdown_source": "../packages/components/src/navigator/navigator-back-link/README.md",
"parent": "components"
},
{
"title": "NavigatorLink",
"slug": "navigator-link",
"markdown_source": "../packages/components/src/navigator/navigator-link/README.md",
"parent": "components"
},
{
"title": "NavigatorProvider",
"slug": "navigator-provider",
Expand Down