Fix form-submit styles by adding button classes to the submit-button in post-comments block #37245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aristath
added
the
Backport to WP 6.9 Beta/RC
noisysocks
added
[Block] Comments (legacy)
noisysocks
approved these changes
Dec 10, 2021
Member
noisysocks
left a comment
noisysocks
left a comment
There was a problem hiding this comment.
I tested this locally and it fixed the bug identified in WordPress/twentytwentytwo#281 👍
Two comments, but I'll pre-approve so that you can merge on Friday in time for beta 3.
aristath
force-pushed
the
fix/comments-block-submit-classes
branch
from
bd5a9d8 to
cf4200e
Compare
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Dec 13, 2021
…in post-comments block (#37245) * Add button classes to the comments form * remove function_exists check
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue reported in WordPress/twentytwentytwo#281
Should be backported to WP5.9.
Since we split the post-comments block this doesn't work as expected because these changes were moved to the post-comments-form block (which is not being backported to WP Core yet). The changes must therefore also exist in the post-comments block for backwards-compatibility purposes with WP 5.9.
Checklist:
*.native.jsfiles for terms that need renaming or removal).