Skip to content

Site Editor: Document Actions: add SR text to heading 1 #37271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kevin940726 merged 2 commits into from
Dec 10, 2021
Merged

Site Editor: Document Actions: add SR text to heading 1 #37271

kevin940726 merged 2 commits into from
Dec 10, 2021

Conversation

@alexstine
Copy link
Contributor

@alexstine alexstine commented Dec 10, 2021 •
edited
Loading

Description

In the Site Editor, I added the screen reader text before the main heading 1 in to the heading 1 that way all text is read. Text should still remain visually hidden but the page should flow much better for screen reader users.

How has this been tested?

I tested using NVDA screen reader in Firefox on Windows 10.

Screenshots

Types of changes

Bug fix.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@alexstine alexstine self-assigned this Dec 10, 2021
@alexstine alexstine added [Feature] Full Site Editing [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Dec 10, 2021
@alexstine alexstine requested a review from talldan December 10, 2021 04:50
kevin940726
kevin940726 approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@kevin940726 kevin940726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Maybe it'll be better to combine "Editing:" and the title together into a single translated text though, so that different locale can rearrange the order of them. But we can do that as a follow-up if needed.

@kevin940726 kevin940726 added the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 10, 2021
@kevin940726
Copy link
Member

kevin940726 commented Dec 10, 2021

E2E tests are failing and seem related to this PR though.

@kevin940726 kevin940726 merged commit ef384b3 into WordPress:trunk Dec 10, 2021
@github-actions github-actions bot added this to the Gutenberg 12.2 milestone Dec 10, 2021
@alexstine alexstine deleted the add/sr-text-to-h1-editor branch December 10, 2021 07:03
@noisysocks noisysocks removed the Backport to WP 6.9 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Dec 13, 2021
noisysocks pushed a commit that referenced this pull request Dec 13, 2021
@alexstine @noisysocks
Site Editor: Document Actions: add SR text to heading 1 (#37271)
550e223 
* Site Editor: Document Actions: add SR text to heading 1.

* Try to fix E2E.
@noisysocks noisysocks mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevin940726 kevin940726 kevin940726 approved these changes

@noisysocks noisysocks Awaiting requested review from noisysocks

@youknowriad youknowriad Awaiting requested review from youknowriad

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@jameskoster jameskoster Awaiting requested review from jameskoster

@sarayourfriend sarayourfriend Awaiting requested review from sarayourfriend

@talldan talldan Awaiting requested review from talldan

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@nerrad nerrad Awaiting requested review from nerrad nerrad is a code owner

@ntwb ntwb Awaiting requested review from ntwb ntwb is a code owner

Assignees

@alexstine alexstine

Labels

[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site [Type] Enhancement A suggestion for improvement.

Projects

None yet

Milestone

Gutenberg 12.2

Development

Successfully merging this pull request may close these issues.

3 participants

@alexstine @kevin940726 @noisysocks