Skip to content

CustomSelectControl: Update to use a Popover component for rendering the internals #37272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 13 commits into from
Closed

CustomSelectControl: Update to use a Popover component for rendering the internals #37272

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
967c90f
Try using Popover component in custom select control
andrewserong Dec 10, 2021
73b385b
Remove anchorRect prop
andrewserong Dec 10, 2021
0bdd715
Switch to using the DropdownMenu component
andrewserong Dec 13, 2021
2b58993
Explore overriding role attributes to semantically indicate that we a…
andrewserong Dec 14, 2021
acdb9c1
Rename select role to listbox
andrewserong Dec 14, 2021
0304b70
Switch back to using Popover component, add useResizeObserver for set…
andrewserong Dec 15, 2021
b59b6a7
Revert change to DropdownMenu component
andrewserong Dec 15, 2021
b8fc4d5
Remove unnecessary nesting
andrewserong Dec 15, 2021
509e015
Add anchorRef and merge refs with downshift's toggle button ref to al…
andrewserong Dec 16, 2021
e178699
Move the anchorRef up to the container, calculate width factoring in …
andrewserong Dec 17, 2021
8ed3a03
Add changelog entry
andrewserong Dec 17, 2021
d46ae30
Move width calculation to negative margin, switch to width instead of…
andrewserong Dec 20, 2021
f261d3b
Try to fix scrollbar issues
andrewserong Dec 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Try to fix scrollbar issues
  • Loading branch information
@andrewserong
andrewserong committed Dec 23, 2021
commit f261d3b7b6d6e572e86dddd1f2d779da5bfa50ae
12 changes: 11 additions & 1 deletion packages/components/src/custom-select-control/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
max-height: 400px;
overflow: auto;
padding: 0;
margin: 0 -$border-width; // Allow width value to include the Popover border width.
margin: 0 (-$border-width); // Allow width value to include the Popover border width.
z-index: z-index(".components-popover");
}

Expand Down Expand Up @@ -78,3 +78,13 @@
margin-bottom: 0;
}
}

.components-custom-select-control__popover {
&.components-popover {
.components-popover__content {
// Prevent the Popover scrollbars so that
// the scrollbars are only handled by the Menu.
overflow: hidden;
}
}
}