ToolsPanel: Allow items to register when panelId is null #37273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
Merged
7 tasks
|
Size Change: +25 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Dec 13, 2021
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
This is looking good to me @aaronrobertshaw! The logic of rendering the ToolsPanelItem when the ToolsPanel is null looks clear, the added test makes good sense, and I couldn't find any issues testing this in isolation or with it rebased on top of #37216 — tested with a mix of paragraph, heading and columns blocks, and switching between different blocks with a variety of settings.
LGTM!
ciampo
approved these changes
Dec 13, 2021
This helps make the ToolsPanel compatible for use when multiple blocks are selected and the original approach setting the panelId as the block's clientId cannot work.
aaronrobertshaw
force-pushed
the
update/tools-panel-allow-null-id
branch
from
806b842 to
073087f
Compare
Contributor
Author
|
I've had to refine the logic around panel item registration and deregistration. The changes effectively tighten up when this occurs, specifically so that selecting multiple blocks in reverse order doesn't cause attributes to be reset. The unit tests were extended to cover this edge case. A new test ensuring orphaned panel items don't occur was also added. |
andrewserong
approved these changes
Dec 17, 2021
Contributor
andrewserong
left a comment
andrewserong
left a comment
There was a problem hiding this comment.
Nice work refining the logic @aaronrobertshaw and thanks for adding in the test to check for orphaned panel items, that all looks good to me.
Just re-tested and it's still working well:
✅ Tests pass and all Storybook examples still work well
✅ Featured Image block's conditionally rendered scale control works
✅ Test that injected controls do not persist between block selections (did lots of switching between blocks, e.g. Cover to Group to Post Featured Image
✅ Tested multiple block selection within block editor with this PR rebased on #37216
LGTM! 🎉
aaronrobertshaw
added
the
Backport to WP 6.9 Beta/RC
Contributor
Author
|
As this is required for the regression fix for multi-selections and the typography block support I've added the backport label to this as well. See #37216 (comment) |
tellthemachines
removed
the
Backport to WP 6.9 Beta/RC
tellthemachines
pushed a commit
that referenced
this pull request
Dec 21, 2021
noisysocks
added a commit
that referenced
this pull request
Jan 4, 2022
)" This reverts commit 4ada4e7.
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
This helps make the ToolsPanel compatible for use when multiple blocks are selected and the original approach setting the panelId as the block's clientId cannot work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Description
When multiple blocks are selected the
panelIdapplied to theToolsPanelisnull. This PR updates the checks restricting panel item registration to allow them to register in this scenario.Changes include:
ToolsPanelItemhookHow has this been tested?
npm run test-unit packages/components/src/tools-panel/testTypes of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).