Block Editor: Avoid wiping out inner block controller content when ungrouping #37274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Package] Block editor
|
Size Change: +56 B (0%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Dec 10, 2021
|
|
||
| // The blocks in block selection don't include inner blocks for the inner block controller. | ||
| // We've to add them manually to avoid data loss. | ||
| const newBlocks = innerBlocks.map( ( block ) => { |
Contributor
There was a problem hiding this comment.
Should this be recursive? Also have you tried converting a TP to Group -> Ungroup -> Group again? In my testing fails.
I think this is something that needs to be handled elsewhere and probably in use-block-sync, but I haven't pinpointed yet the proper change.
Member
Author
There was a problem hiding this comment.
Yes, this should be recursive if we go with a similar solution.
As I mentioned, this solution doesn't work quite well. I decided to share anyway as a starting point and for detail.
I think this is something that needs to be handled elsewhere and probably in use-block-sync, but I haven't pinpointed yet the proper change.
Same 😅
Contributor
|
I'd like to take some time to see if I can figure out the root issue, I'll keep you updated. |
Member
Author
|
I am closing this in favor of #37280. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #36788.
When grouping and ungrouping inner block controller blocks (Template Parts, Reusable Blocks), their content is wiped out.
Why
getBlocksByClientIdfor block(s) data, which calls thegetBlockinternally.getBlockwon't return inner blocks when another entity controls them, aka "Controlled Inner Blocks."innerBlocks.I thought I could manually set inner blocks for controlled entities (see current code), but this method only works halfway. The controlled inner blocks still get deleted after saving the post.
My best guess is that this has something to do with how the
useBlockSyncworks.@noahtallen, @youknowriad I would appreciate any feedback you can provide for this issue 🙇
How has this been tested?
Types of changes
Bugfix
Checklist:
*.native.jsfiles for terms that need renaming or removal).