[Block Library]: Fix editable post blocks in Query Loop with zero queryId
#37629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Bug
ntsekouras
requested review from
Mamaduka,
annezazu,
aristath,
carolinan,
cbravobernal and
youknowriad
|
Size Change: +9 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Dec 27, 2021
Member
Mamaduka
left a comment
Mamaduka
left a comment
There was a problem hiding this comment.
Changes look good to me. Thanks, Nik.
noisysocks
removed
the
Backport to WP 6.9 Beta/RC
noisysocks
pushed a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug all along in some Post blocks that were editable inside a
Query Loopwhen thequeryIdwas zero due to the!! queryIdcheck. This was surfaced by @annezazu here.What happened was that for a long time we were testing with tt1-blocks that had a
queryId=1in its templates and when we insert aQuery Loopblock inside an editor it first renders theQuerypatterns making it impossible forqueryIdto be zero. But with other themes that omit thequeryIdin their templates (as they should),useInstanceIdcan return zero making the check invalid and the post blocks inside it being editable.This PR solves that.
Testing instructions