Skip to content

Borders: Use new border control components in block support #37770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 27 commits into from
Apr 14, 2022
Merged

Borders: Use new border control components in block support #37770

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
09a7d05
Add support for individual side borders via BorderBoxControl
aaronrobertshaw Feb 1, 2022
136e6af
Tweak table styles to be less ugly with split borders
aaronrobertshaw Feb 1, 2022
9b026e7
Update Search block for individual border support
aaronrobertshaw Feb 3, 2022
7ed686c
Extend theme.json class to support individual borders
aaronrobertshaw Mar 23, 2022
45f6393
Update positioning of border control popovers
aaronrobertshaw Mar 25, 2022
344314a
Update border related properties in theme.json schema
aaronrobertshaw Apr 1, 2022
6fdef6f
Update living theme.json md file
aaronrobertshaw Apr 1, 2022
5ec71d4
Keep linter happy
aaronrobertshaw Apr 1, 2022
8672d6a
Fix border skip serialization checks
aaronrobertshaw Apr 1, 2022
eb92cbf
Fix typos
aaronrobertshaw Apr 4, 2022
301f755
Only implode classes and styles in primary application function
aaronrobertshaw Apr 4, 2022
e3266b6
Remove unneeded border radius control class
aaronrobertshaw Apr 4, 2022
0b828e4
Improve comment punctuation
aaronrobertshaw Apr 4, 2022
ec3ffb9
Prevent empty sideBorderColors object for split borders
aaronrobertshaw Apr 4, 2022
649f51e
Add explanatory comment
aaronrobertshaw Apr 4, 2022
ad51e60
Enable alpha colors for borders
aaronrobertshaw Apr 4, 2022
b43ba59
Fix whitespace typo
aaronrobertshaw Apr 7, 2022
516d819
Switch to preset approach for named colors
aaronrobertshaw Apr 8, 2022
2c8fcca
Fix linting errors
aaronrobertshaw Apr 8, 2022
5e700d1
Clean up split border style generation
aaronrobertshaw Apr 8, 2022
4c1d414
Take info from style.border.side.color value instead of colorSlug
oandregal Apr 8, 2022
5f74e1b
Take info from style.border.side.color value instead of colorSlug (cl…
oandregal Apr 8, 2022
06de976
Take info from style.border.side.color (search block)
oandregal Apr 8, 2022
f260382
Fix PHP lint issues
oandregal Apr 8, 2022
461717d
Remove obsolete colorSlug attributes from border test
aaronrobertshaw Apr 12, 2022
84f4f4b
Prevent editor forced shorthand styles applying incorrect styles
aaronrobertshaw Apr 13, 2022
ea485d5
Make skip serialization check consistent
aaronrobertshaw Apr 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove obsolete colorSlug attributes from border test
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Apr 13, 2022
commit 461717d1150e68a461890c0996a52711927da992
28 changes: 12 additions & 16 deletions phpunit/block-supports/border-test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,28 +430,24 @@ function test_split_borders_with_named_colors() {
'style' => array(
'border' => array(
'top' => array(
'width' => '2px',
'style' => 'dashed',
'color' => 'var:preset|color|red',
'colorSlug' => 'red',
'width' => '2px',
'style' => 'dashed',
'color' => 'var:preset|color|red',
),
'right' => array(
'width' => '0.25rem',
'style' => 'dotted',
'color' => 'var:preset|color|green',
'colorSlug' => 'green',
'width' => '0.25rem',
'style' => 'dotted',
'color' => 'var:preset|color|green',
),
'bottom' => array(
'width' => '0.5em',
'style' => 'solid',
'color' => 'var:preset|color|blue',
'colorSlug' => 'blue',
'width' => '0.5em',
'style' => 'solid',
'color' => 'var:preset|color|blue',
),
'left' => array(
'width' => '1px',
'style' => 'solid',
'color' => 'var:preset|color|yellow',
'colorSlug' => 'yellow',
'width' => '1px',
'style' => 'solid',
'color' => 'var:preset|color|yellow',
),
),
),
Expand Down