Remove color from code theme.scss. #37816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Size Change: -27 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jan 10, 2022
Contributor
Author
|
Thank you. Is this something to backport? The color has been there for a while, and affects only themes that opt in to opinionated styles, so I don't have a strong opinion. |
Member
|
Personally I don't think it needs to be backported, especially this late in the game. Good fix for the future though, thanks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #36282 (comment).
When a theme opts into opinionated block styles (which loads theme.scss files bundled with blocks), some base styles are applied to the Code block:
Those base styles include a dark text color, which is problematic if you use a black background. This PR removes that explicitly defined text color, so the color is instead inherited:
I would've liked to go further and affect the border as well, but omitted that to keep things small, and because the gray already works well enough in dark themes, and actual border color is applied to the parent
preelement instead. So that's something to probably look at separately!How has this been tested?
Insert a code block with some code, in a theme that uses opinionated styles (such as TwentyTwentyTwo), and verify that code is legible on both light and dark backgrounds.
Checklist:
*.native.jsfiles for terms that need renaming or removal).