Skip to content

[Block Library]: Remove font family support from 5.9 blocks #37911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ntsekouras wants to merge 1 commit into from
Closed

[Block Library]: Remove font family support from 5.9 blocks #37911

ntsekouras wants to merge 1 commit into from

Conversation

@ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Jan 12, 2022

Resolves: #37826

From the issue:

While testing 5.9 RC1 I found that the font family selection for paragraphs was not yet available. @carolinan and @bph mentioned the issue #37586, however, it was discussed to revert that feature as the Webfont API is not ready yet, so it got removed with PR #37815.

While further testing I noticed that it is still in use by several blocks and to avoid unneccessary confusion in 5.9, I'd suggest to have it removed from those blocks as well:

There are nine blocks in core that have this setting.

@ntsekouras ntsekouras added the [Package] Block library /packages/block-library label Jan 12, 2022
@ntsekouras ntsekouras requested a review from ajitbohra as a code owner January 12, 2022 09:51
@ntsekouras ntsekouras self-assigned this Jan 12, 2022
@ntsekouras ntsekouras mentioned this pull request Jan 12, 2022
Closed
@ntsekouras ntsekouras marked this pull request as draft January 12, 2022 10:02
@ntsekouras ntsekouras closed this Jan 12, 2022
@aristath aristath deleted the revert/font-family-support-from-blocks branch January 13, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtias mtias Awaiting requested review from mtias

@oandregal oandregal Awaiting requested review from oandregal

@aristath aristath Awaiting requested review from aristath

@MaggieCabrera MaggieCabrera Awaiting requested review from MaggieCabrera

@ramonjd ramonjd Awaiting requested review from ramonjd

@carolinan carolinan Awaiting requested review from carolinan

@aaronrobertshaw aaronrobertshaw Awaiting requested review from aaronrobertshaw

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@tellthemachines tellthemachines Awaiting requested review from tellthemachines

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy will be requested when the pull request is marked ready for review fabiankaegy is a code owner

Assignees

@ntsekouras ntsekouras

Labels

[Package] Block library /packages/block-library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Revert Font Family Support from various blocks for 5.9

2 participants

@ntsekouras