Skip to content

Fix useFocusFirstElement in non-contenteditable Blocks #37934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexstine merged 39 commits into from
Mar 15, 2022
Merged

Fix useFocusFirstElement in non-contenteditable Blocks #37934

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
160067a
Finally fix selector in test I think.
alexstine Jan 14, 2022
1251408
If not contenteditable Block, find next focussable element.
alexstine Jan 31, 2022
e735aa3
Try to make tests stable.
alexstine Jan 31, 2022
3c6311d
Try to fix tests.
alexstine Jan 31, 2022
f18270d
Update snapshot.
alexstine Jan 31, 2022
8f352e8
Fix focus getting stuck on child Block wrapper. Adjust to find only s…
alexstine Jan 31, 2022
b947e8c
Revert tests and start fresh.
alexstine Feb 1, 2022
6ee7747
More work on tests.
alexstine Feb 1, 2022
818115e
Add td to whitelisted elements. Check to see if first element has foc…
alexstine Feb 1, 2022
21e15dd
Revert some code.
alexstine Feb 2, 2022
e3f373b
Back to test fixing.
alexstine Feb 2, 2022
038d1b8
Try again to prevent focus in child Blocks. Tests should pass this ti…
alexstine Feb 2, 2022
be095b8
Update another snapshot.
alexstine Feb 3, 2022
fbffdf5
More work on E2E tests.
alexstine Feb 16, 2022
c421834
Cleanup code and try to fix more tests.
alexstine Feb 21, 2022
5007b54
Fix snapshot.
alexstine Feb 22, 2022
cc894c4
Maybe fix another snapshot.
alexstine Feb 22, 2022
643e470
Make sure returning early doesn't prevent false positive of still hav…
alexstine Feb 22, 2022
df7bf85
Update snapshots.
alexstine Feb 22, 2022
51d8e7a
Fix test snapshot.
tellthemachines Feb 23, 2022
316b9cc
Update tests with focus order changes.
tellthemachines Feb 28, 2022
8969d23
Make the implementation more stable. Fix the List View focus bug.
alexstine Mar 1, 2022
ce52e45
Use target everywhere. Add a check for Block Inserter trigger.
alexstine Mar 1, 2022
01e0210
Merge branch 'trunk' of github.com:wordpress/gutenberg into try/acces…
alexstine Mar 1, 2022
c0027c4
Use Tab to exit the toolbar so blocks could be navigated. Only seems …
alexstine Mar 1, 2022
41ffcec
Fix failing test and update snapshot.
tellthemachines Mar 4, 2022
cdea00f
Fix group block still places focus on Add block button. Add some E2E …
alexstine Mar 4, 2022
855bae1
Merge branch 'trunk' of github.com:wordpress/gutenberg into try/acces…
alexstine Mar 4, 2022
4ac00b0
Merge branch 'try/accessible-block-content-dialog' of github.com:word…
alexstine Mar 4, 2022
72a5933
Fix code comment.
alexstine Mar 4, 2022
065ba6f
Fix bugs.
alexstine Mar 5, 2022
53b7cd5
Merge branch 'trunk' of github.com:wordpress/gutenberg into try/acces…
alexstine Mar 5, 2022
c2a8ba9
Formatting fixes.
alexstine Mar 5, 2022
300c302
Update to use class name.
alexstine Mar 5, 2022
b66fbd2
Try again to fix my own test.
alexstine Mar 5, 2022
f8871ca
Merge branch 'trunk' of github.com:wordpress/gutenberg into try/acces…
alexstine Mar 9, 2022
17f1dd0
Merge branch 'trunk' of github.com:wordpress/gutenberg into try/acces…
alexstine Mar 14, 2022
3f4df14
Try again to rewrite toolbar roving tabindex now that E2E is working.
alexstine Mar 14, 2022
948f325
Better code commenting.
alexstine Mar 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
More work on tests.
  • Loading branch information
@alexstine @tellthemachines
alexstine authored and tellthemachines committed Mar 1, 2022
commit 6ee7747757214e5d02b11b81e0148c009313eb74
8 changes: 2 additions & 6 deletions packages/e2e-tests/specs/editor/various/__snapshots__/writing-flow.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,8 @@ exports[`Writing Flow should not prematurely multi-select 1`] = `
<!-- /wp:paragraph -->"
`;

exports[`Writing Flow should only consider the content as one tab stop 1`] = `"<!-- wp:table /-->"`;

exports[`Writing Flow should preserve horizontal position when navigating vertically between blocks 1`] = `
"<!-- wp:paragraph -->
<p>abc</p>
Expand All @@ -297,9 +299,3 @@ exports[`Writing Flow should remember initial vertical position 1`] = `
<p><br>2</p>
<!-- /wp:paragraph -->"
`;

exports[`Writing Flow should only consider the content as one tab stop 1`] = `
"<!-- wp:table -->
<figure class=\\"wp-block-table\\"><table><tbody><tr><td></td><td>2</td></tr><tr><td></td><td></td></tr></tbody></table></figure>
<!-- /wp:table -->"
`;
4 changes: 2 additions & 2 deletions packages/e2e-tests/specs/editor/various/writing-flow.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ const addParagraphsAndColumnsDemo = async () => {
`//*[contains(@class, "components-autocomplete__result") and contains(@class, "is-selected") and contains(text(), 'Columns')]`
);
await page.keyboard.press( 'Enter' );
await page.click( ':focus [aria-label="Two columns; equal split"]' );
await page.click( ':focus .block-editor-button-block-appender' );
await page.click( 'button[aria-label="Two columns; equal split"]' );
await page.click( 'button.block-editor-button-block-appender' );
await page.waitForSelector( '.block-editor-inserter__search input:focus' );
await page.keyboard.type( 'Paragraph' );
await pressKeyTimes( 'Tab', 2 ); // Tab to paragraph result.
Expand Down