Skip to content

ToolsPanel: Memoize callbacks and context to prevent unnecessary rerenders #38037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronrobertshaw merged 5 commits into from
Jan 21, 2022
Merged

ToolsPanel: Memoize callbacks and context to prevent unnecessary rerenders #38037

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1abb6b6
Prevent BlockSupportToolsPanel resetAll triggering rerenders
aaronrobertshaw Jan 17, 2022
f88afe0
Add memoization to ToolsPanel callbacks and context
aaronrobertshaw Jan 18, 2022
fd38f4d
Add changelog
aaronrobertshaw Jan 18, 2022
da253ea
Make hook dependency arrays exhaustive
aaronrobertshaw Jan 18, 2022
3e1585c
Update BlockSupportToolsPanel hook dependencies
aaronrobertshaw Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update BlockSupportToolsPanel hook dependencies
  • Loading branch information
@aaronrobertshaw
aaronrobertshaw committed Jan 18, 2022
commit 3e1585c630d5889f2e587efb2f09ff93b01df438
6 changes: 4 additions & 2 deletions packages/block-editor/src/components/inspector-controls/block-support-tools-panel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,10 +52,12 @@ export default function BlockSupportToolsPanel( { children, group, label } ) {
updateBlockAttributes( clientIds, newAttributes, true );
},
[
hasMultiSelection,
cleanEmptyObject,
getBlockAttributes,
getMultiSelectedBlockClientIds,
hasMultiSelection,
panelId,
getBlockAttributes,
updateBlockAttributes,
]
);

Expand Down